CLI instance is now created and initialized lazily #1615
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
before creating one)
our contributing guidelines
UPGRADING.md
has been updated with a migration guide (for breaking changes)Enhances the handling of the internal instance used by the
cli
package.The functions that create and initialize the internal instance used in the
cli
package never check if an instance has been already created nor initialized.Subsequent calls of
instance.Create
would create multiple instances, callinginstance.Init
would reinitialized the specified instance even if already initialized.The functions that create and initialize the internal instance used in the
cli
package now check if an instance has been already created nor initialized.Calling of
instance.Create
will create a new instance and cache it, suqsequent calls will return the same instance.Calling
instance.Init
won't reinitialized the specified instance if already initialized.titled accordingly?
Nope.
Closes #1453.
See how to contribute