Enhance i18n:check task
#1578
Merged
Enhance i18n:check task
#1578
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silvanocerza
added
type: enhancement
i18n:check task used to verify only if the source en.po file was up to date. The new process instead verifies that all translations are up to date by downloading them directly from Transifex. The previous process was causing some issues since after uploading the en.po file Transifex would change its formatting, meaning when calling i18n:pull we would download a file containing the same information but formatted in a different way and that made the i18n:check command fail. By making the i18n:check task call i18n:pull instead of i18n:update we don't have issues with the formatting anymore. This change also covers a corner-case that would occur when the en.po file wasn't updated since a long time, the i18n:check wouldn't fail because the en.po was the same as before but that wouldn't mean that the translations were up to date with the latest from Transifex.
silvanocerza
force-pushed
the
scerza/enhance-i18n-check
branch
from
28c3afb to
1e52dbb
Compare
cmaglie
approved these changes
Dec 2, 2021
umbynos
pushed a commit
that referenced
this pull request
Dec 7, 2021
i18n:check task used to verify only if the source en.po file was up to date. The new process instead verifies that all translations are up to date by downloading them directly from Transifex. The previous process was causing some issues since after uploading the en.po file Transifex would change its formatting, meaning when calling i18n:pull we would download a file containing the same information but formatted in a different way and that made the i18n:check command fail. By making the i18n:check task call i18n:pull instead of i18n:update we don't have issues with the formatting anymore. This change also covers a corner-case that would occur when the en.po file wasn't updated since a long time, the i18n:check wouldn't fail because the en.po was the same as before but that wouldn't mean that the translations were up to date with the latest from Transifex.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)Enhances the
i18n:checktask to also verify that translations files other thanen.poare up to date.i18n:checkverifies thaten.pohas the same data and formatting as the one generated byi18n:update.i18n:checktask used to verify only if the sourceen.pofile was up to date. The new process instead verifies that all translations are up to date by downloading them directly from Transifex.The previous process was causing some issues since after uploading the
en.pofile Transifex would change its formatting, meaning when callingi18n:pullwe would download a file containing the same information but formatted in a different way and that made thei18n:checkcommand fail.By making the
i18n:checktask calli18n:pullinstead ofi18n:updatewe don't have issues with the formatting anymore.This change also covers a corner-case that would occur when the
en.pofile wasn't updated since a long time, thei18n:checkwouldn't fail because theen.powas the same as before but that wouldn't mean that the translations were up to date with the latest from Transifex.titled accordingly?
Nope.
Fixes #1560.
See how to contribute