Skip to content

Split CI execution of integration tests #1526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 25, 2021

Conversation

silvanocerza
Copy link
Contributor

@silvanocerza silvanocerza commented Oct 20, 2021

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • What kind of change does this PR introduce?

This PR changes the way integration tests are run in the CI so it takes less time to run the whole tests suite.
This greatly enhances the contributors' experience so they don't have to wait almost an hour to merge a PR, or even more in case of failures.

  • What is the current behavior?

Integration tests are run concurrently two at a time per runner.

  • What is the new behavior?

Each runner now runs just a single file, this cuts the execution time of the full tests suite more than half.

test_compile.py has been split into 4 parts since it was taking quite a bit to run even with this solution.

Nope.

  • Other information:

None.


See how to contribute

@silvanocerza silvanocerza force-pushed the scerza/integration-tests-speedup branch from 1c9472d to 898437c Compare October 20, 2021 10:13
@silvanocerza silvanocerza force-pushed the scerza/integration-tests-speedup branch from 898437c to eb7c96d Compare October 20, 2021 10:33
@per1234 per1234 added topic: infrastructure Related to project infrastructure type: enhancement Proposed improvement labels Oct 22, 2021
@silvanocerza silvanocerza force-pushed the scerza/integration-tests-speedup branch 23 times, most recently from 7d7b3f4 to 8aa92a1 Compare October 25, 2021 10:47
@silvanocerza silvanocerza self-assigned this Oct 25, 2021
@silvanocerza silvanocerza marked this pull request as ready for review October 25, 2021 13:03
@silvanocerza silvanocerza force-pushed the scerza/integration-tests-speedup branch from 54c5590 to 32d1e19 Compare October 25, 2021 13:05
@silvanocerza silvanocerza merged commit 8e6f93f into master Oct 25, 2021
@silvanocerza silvanocerza deleted the scerza/integration-tests-speedup branch October 25, 2021 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: infrastructure Related to project infrastructure type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants