Skip to content

fix GetPlatform function ignoring the All field #1521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix GetPlatform function ignoring the All field #1521

wants to merge 1 commit into from

Conversation

umbynos
Copy link
Contributor

@umbynos umbynos commented Oct 19, 2021

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • What kind of change does this PR introduce?

Bug fix

  • What is the current behavior?

#1520

  • What is the new behavior?

The all field inside the PlatformListRequest works correctly now

no

  • Other information:

See how to contribute

@umbynos umbynos added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Oct 19, 2021
@umbynos umbynos requested a review from a team October 19, 2021 16:07
@umbynos umbynos self-assigned this Oct 19, 2021
@per1234 per1234 removed the request for review from a team January 26, 2022 05:48
@ubidefeo ubidefeo mentioned this pull request Apr 6, 2022
Closed
@per1234 per1234 linked an issue Apr 11, 2022 that may be closed by this pull request
The core.GetPlatforms function ignores the all field showing manually installed cores #1520
Closed
@ubidefeo ubidefeo requested a review from cmaglie July 25, 2022 15:12
@alessio-perugini
Copy link
Contributor

Fixed in: #2357

@umbynos umbynos deleted the umbynos/fix_get_platform branch October 24, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmaglie cmaglie Awaiting requested review from cmaglie

Assignees

@umbynos umbynos

Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The core.GetPlatforms function ignores the all field showing manually installed cores
2 participants
@umbynos @alessio-perugini