Drop `go.rice` library in favor of golang native `embed` (available from go1.16) #1513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

cmaglie merged 2 commits into arduino:master from cmaglie:drop_gorice_lib

Oct 18, 2021

Member

cmaglie commented Oct 15, 2021

Please check if the PR fulfills these requirements

The PR has no duplicates (please search among the Pull Requests before creating one)
The PR follows our contributing guidelines
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)
UPGRADING.md has been updated with a migration guide (for breaking changes)

What kind of change does this PR introduce?
This PR removes the dependency from go.rice library and replaces it with the embed feature -> https://pkg.go.dev/embed

What is the current behavior?
No changes in behavior.
Does this PR introduce a breaking change
No

cmaglie added 2 commits

October 15, 2021 18:49


          Removed 'go.rice' library in favor of 'embed'

73c6043


          fix i18n

aa72b8d

cmaglie requested review from silvanocerza and per1234

October 15, 2021 16:54

silvanocerza approved these changes

View reviewed changes

cmaglie merged commit 6c3c864 into arduino:master

cmaglie deleted the drop_gorice_lib branch

October 18, 2021 10:01

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet