Skip to content

[breaking] Remove old gRPC Monitor service, in favor of new gRPC API based on pluggable monitor #1504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 20, 2022
Merged

[breaking] Remove old gRPC Monitor service, in favor of new gRPC API based on pluggable monitor #1504

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c0ebae3
Removed old Monitor gRPC service
cmaglie Jun 6, 2022
cdab591
Updated UPGRADING.md
cmaglie Oct 11, 2021
fceaba9
Fixed broken links
cmaglie Oct 11, 2021
04a248f
Updated licensed cache
cmaglie Jun 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
63 changes: 0 additions & 63 deletions .licenses/go/google.golang.org/protobuf/encoding/protojson.dep.yml
View file
Open in desktop

This file was deleted.

62 changes: 0 additions & 62 deletions .licenses/go/google.golang.org/protobuf/internal/encoding/json.dep.yml
View file
Open in desktop

This file was deleted.

62 changes: 0 additions & 62 deletions .licenses/go/google.golang.org/protobuf/types/known/structpb.dep.yml
View file
Open in desktop

This file was deleted.

2 changes: 0 additions & 2 deletions Taskfile.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,15 +198,13 @@ tasks:
desc: Compile protobuf definitions
cmds:
- '{{ default "protoc" .PROTOC_BINARY }} --proto_path=rpc --go_out=./rpc --go_opt=paths=source_relative --go-grpc_out=./rpc --go-grpc_opt=paths=source_relative ./rpc/cc/arduino/cli/commands/v1/*.proto'
- '{{ default "protoc" .PROTOC_BINARY }} --proto_path=rpc --go_out=./rpc --go_opt=paths=source_relative --go-grpc_out=./rpc --go-grpc_opt=paths=source_relative ./rpc/cc/arduino/cli/monitor/v1/*.proto'
- '{{ default "protoc" .PROTOC_BINARY }} --proto_path=rpc --go_out=./rpc --go_opt=paths=source_relative --go-grpc_out=./rpc --go-grpc_opt=paths=source_relative ./rpc/cc/arduino/cli/settings/v1/*.proto'
- '{{ default "protoc" .PROTOC_BINARY }} --proto_path=rpc --go_out=./rpc --go_opt=paths=source_relative --go-grpc_out=./rpc --go-grpc_opt=paths=source_relative ./rpc/cc/arduino/cli/debug/v1/*.proto'

protoc:docs:
desc: Generate docs for protobuf definitions
cmds:
- '{{ default "protoc" .PROTOC_BINARY }} --doc_out=./docs/rpc --doc_opt=markdown,commands.md --proto_path=rpc ./rpc/cc/arduino/cli/commands/v1/*.proto'
- '{{ default "protoc" .PROTOC_BINARY }} --doc_out=./docs/rpc --doc_opt=markdown,monitor.md --proto_path=rpc ./rpc/cc/arduino/cli/monitor/v1/*.proto'
- '{{ default "protoc" .PROTOC_BINARY }} --doc_out=./docs/rpc --doc_opt=markdown,settings.md --proto_path=rpc ./rpc/cc/arduino/cli/settings/v1/*.proto'
- '{{ default "protoc" .PROTOC_BINARY }} --doc_out=./docs/rpc --doc_opt=markdown,debug.md --proto_path=rpc ./rpc/cc/arduino/cli/debug/v1/*.proto'

Expand Down
70 changes: 0 additions & 70 deletions arduino/monitors/null.go
View file
Open in desktop

This file was deleted.

65 changes: 0 additions & 65 deletions arduino/monitors/serial.go
View file
Open in desktop

This file was deleted.

25 changes: 0 additions & 25 deletions arduino/monitors/types.go
View file
Open in desktop

This file was deleted.

4 changes: 0 additions & 4 deletions cli/daemon/daemon.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ import (
"github.com/arduino/arduino-cli/i18n"
srv_commands "github.com/arduino/arduino-cli/rpc/cc/arduino/cli/commands/v1"
srv_debug "github.com/arduino/arduino-cli/rpc/cc/arduino/cli/debug/v1"
srv_monitor "github.com/arduino/arduino-cli/rpc/cc/arduino/cli/monitor/v1"
srv_settings "github.com/arduino/arduino-cli/rpc/cc/arduino/cli/settings/v1"
"github.com/arduino/go-paths-helper"
"github.com/sirupsen/logrus"
Expand Down Expand Up @@ -106,9 +105,6 @@ func runDaemonCommand(cmd *cobra.Command, args []string) {
VersionString: globals.VersionInfo.VersionString,
})

// Register the monitors service
srv_monitor.RegisterMonitorServiceServer(s, &daemon.MonitorService{})

// Register the settings service
srv_settings.RegisterSettingsServiceServer(s, &daemon.SettingsService{})

Expand Down
Loading