Skip to content

[breaking] Remove old gRPC Monitor service, in favor of new gRPC API based on pluggable monitor #1504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 20, 2022
Merged

[breaking] Remove old gRPC Monitor service, in favor of new gRPC API based on pluggable monitor #1504

merged 4 commits into from
Jun 20, 2022

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Oct 11, 2021

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • What kind of change does this PR introduce?
    Remove the now obsolete gRPC Monitor service
  • Does this PR introduce a breaking change, and is titled accordingly?
    Yes, even if we provide a better alternative, we are removing an API.

@cmaglie cmaglie force-pushed the old_monitor_cleanup branch from 8c9da48 to ce8bdd5 Compare October 11, 2021 15:59
@cmaglie cmaglie force-pushed the old_monitor_cleanup branch from ce8bdd5 to bdb9212 Compare November 23, 2021 08:59
@per1234 per1234 added topic: code Related to content of the project itself topic: gRPC Related to the gRPC interface type: enhancement Proposed improvement labels Jan 12, 2022
@fstasi
Copy link

fstasi commented Jan 24, 2022 •
edited
Loading

blocked by arduino/arduino-ide#769

@fstasi fstasi added this to the arduino-cli 0.22.0 milestone Jan 25, 2022
@cmaglie cmaglie force-pushed the old_monitor_cleanup branch from bdb9212 to de7264f Compare June 1, 2022 16:39
@cmaglie cmaglie requested a review from a team June 1, 2022 18:07
umbynos
umbynos reviewed Jun 6, 2022
View reviewed changes
umbynos
umbynos suggested changes Jun 6, 2022
View reviewed changes
Copy link
Contributor

@umbynos umbynos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments

@cmaglie cmaglie force-pushed the old_monitor_cleanup branch from c2ffc88 to f24b6e2 Compare June 6, 2022 10:05
@cmaglie cmaglie force-pushed the old_monitor_cleanup branch from f24b6e2 to 04a248f Compare June 6, 2022 10:06
@cmaglie cmaglie merged commit 4badf90 into arduino:master Jun 20, 2022
@cmaglie cmaglie deleted the old_monitor_cleanup branch June 20, 2022 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@umbynos umbynos umbynos approved these changes

Assignees

@cmaglie cmaglie

Labels
topic: code Related to content of the project itself topic: gRPC Related to the gRPC interface type: enhancement Proposed improvement
Projects
None yet
Milestone
arduino-cli 0.24.0
Development

Successfully merging this pull request may close these issues.
4 participants
@cmaglie @fstasi @umbynos @per1234