[pluggable monitor] various minor refactors #1501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silvanocerza
reviewed
Oct 8, 2021
silvanocerza
reviewed
Oct 8, 2021
silvanocerza
reviewed
Oct 8, 2021
silvanocerza
suggested changes
Oct 8, 2021
Co-authored-by: Silvano Cerza <[email protected]>
silvanocerza
approved these changes
Oct 8, 2021
d-a-v
pushed a commit
to d-a-v/arduino-cli
that referenced
this pull request
Oct 14, 2021
* Factored pluggable monitor creation * Factored out code duplication * EnumerateMonitorPortSettings does require only protocol * Monitor.Open does require only address and protocol * Added GetPortAddressAndProtocol helper * fix i18n * Apply suggestions from code review Co-authored-by: Silvano Cerza <[email protected]>
d-a-v
pushed a commit
to d-a-v/arduino-cli
that referenced
this pull request
Oct 14, 2021
* Factored pluggable monitor creation * Factored out code duplication * EnumerateMonitorPortSettings does require only protocol * Monitor.Open does require only address and protocol * Added GetPortAddressAndProtocol helper * fix i18n * Apply suggestions from code review Co-authored-by: Silvano Cerza <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)This PR does some minor refactors needed for future improvements.