Skip to content

[pluggable monitor] Added gRPC calls. #1492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion commands/daemon/daemon.go
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,9 @@ import (

// ArduinoCoreServerImpl FIXMEDOC
type ArduinoCoreServerImpl struct {
rpc.UnimplementedArduinoCoreServiceServer
// Force compile error for unimplemented methods
rpc.UnsafeArduinoCoreServiceServer

VersionString string
}

Expand Down Expand Up @@ -463,3 +465,13 @@ func (s *ArduinoCoreServerImpl) GitLibraryInstall(req *rpc.GitLibraryInstallRequ
}
return stream.Send(&rpc.GitLibraryInstallResponse{})
}

// EnumerateMonitorPortSettings FIXMEDOC
func (s *ArduinoCoreServerImpl) EnumerateMonitorPortSettings(context.Context, *rpc.EnumerateMonitorPortSettingsRequest) (*rpc.EnumerateMonitorPortSettingsResponse, error) {
return nil, status.New(codes.Unimplemented, "Not implemented").Err()
}

// Monitor FIXMEDOC
func (s *ArduinoCoreServerImpl) Monitor(stream rpc.ArduinoCoreService_MonitorServer) error {
return status.New(codes.Unimplemented, "Not implemented").Err()
}
2 changes: 1 addition & 1 deletion i18n/data/en.po
Original file line number Diff line number Diff line change
Expand Up @@ -2923,7 +2923,7 @@ msgstr "no compatible version of %s tools found for the current os"
msgid "no executable specified"
msgstr "no executable specified"

#: commands/daemon/daemon.go:96
#: commands/daemon/daemon.go:98
msgid "no instance specified"
msgstr "no instance specified"

Expand Down
8 changes: 4 additions & 4 deletions i18n/rice-box.go

Large diffs are not rendered by default.

970 changes: 499 additions & 471 deletions rpc/cc/arduino/cli/commands/v1/commands.pb.go

Large diffs are not rendered by default.

8 changes: 8 additions & 0 deletions rpc/cc/arduino/cli/commands/v1/commands.proto
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ import "cc/arduino/cli/commands/v1/common.proto";
import "cc/arduino/cli/commands/v1/board.proto";
import "cc/arduino/cli/commands/v1/compile.proto";
import "cc/arduino/cli/commands/v1/core.proto";
import "cc/arduino/cli/commands/v1/monitor.proto";
import "cc/arduino/cli/commands/v1/upload.proto";
import "cc/arduino/cli/commands/v1/lib.proto";

Expand Down Expand Up @@ -170,6 +171,13 @@ service ArduinoCoreService {

// List the installed libraries.
rpc LibraryList(LibraryListRequest) returns (LibraryListResponse);

// Open a monitor connection to a board port
rpc Monitor(stream MonitorRequest) returns (stream MonitorResponse);

// Returns the parameters that can be set in the MonitorRequest calls
rpc EnumerateMonitorPortSettings(EnumerateMonitorPortSettingsRequest)
returns (EnumerateMonitorPortSettingsResponse);
}

message CreateRequest {}
Expand Down
108 changes: 108 additions & 0 deletions rpc/cc/arduino/cli/commands/v1/commands_grpc.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading