Skip to content

[skip changelog] Fix lib install crash on nightlies #1479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 29, 2021

Conversation

silvanocerza
Copy link
Contributor

@silvanocerza silvanocerza commented Sep 29, 2021

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • What kind of change does this PR introduce?

Fixes a crash happening only on nightly releases.

  • What is the current behavior?

Calling lib install with --zip-path or --git-url flag and config library.enable_unsafe_install set to false on a nightly build makes the CLI crash.

  • What is the new behavior?

Calling lib install with --zip-path or --git-url flag and config library.enable_unsafe_install set to false on a nightly build doesn't crash the CLI anymore.

Nope.

  • Other information:

Fixes #1196.


See how to contribute

@silvanocerza silvanocerza added topic: CLI Related to the command line interface type: bug labels Sep 29, 2021
@silvanocerza silvanocerza requested a review from a team September 29, 2021 09:04
@silvanocerza silvanocerza self-assigned this Sep 29, 2021
@silvanocerza silvanocerza force-pushed the scerza/fix-lib-install-nightly branch from 8317bbf to f75b007 Compare September 29, 2021 09:06
@silvanocerza silvanocerza force-pushed the scerza/fix-lib-install-nightly branch from f75b007 to d2631fb Compare September 29, 2021 09:12
@silvanocerza silvanocerza merged commit 3d5b430 into master Sep 29, 2021
@silvanocerza silvanocerza deleted the scerza/fix-lib-install-nightly branch September 29, 2021 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: CLI Related to the command line interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid nightly VersionString causes error during 'lib install' when 'directories' locations do not exist
2 participants