Skip to content

Some PluggableMonitor client improvements #1475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 29, 2021

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Sep 27, 2021

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • What kind of change does this PR introduce?
    This PR adds a bunch of improvements to the pluggable monitor client:
  1. Added QUIT command support
  2. Use rpc.Port in Open method (as it should be)
  3. Slighlty improved error messages
  4. Applied the same fix we did on PluggableDiscovery client about resource leaking

This PR is preparatory for the bigger Pluggable Monitor implementation.

@silvanocerza
Copy link
Contributor

Add the [skip changelog] before merging please. 🙏

@cmaglie cmaglie merged commit 0a6a83c into arduino:master Sep 29, 2021
@cmaglie cmaglie deleted the monitor_client_improvements branch September 29, 2021 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants