Fixed some resource leaks leading to a "too many open files" error #1465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved the process creation at the very last moment, since StdInPipe and StdOutPipe methods actually creates a OS pipe even if the process is not started later.
Otherwise the resources allocated by the process will be leaked. (pipes, zombie process, etc.)
cmaglie
force-pushed
the
fix_pipes_leak
branch
from
da34705 to
3e75e71
Compare
silvanocerza
approved these changes
Sep 23, 2021
cmaglie
changed the title
cmaglie
changed the title
silvanocerza
added a commit
that referenced
this pull request
Sep 24, 2021
…1465) * Fixed leaking pipes in Discovery command creation Moved the process creation at the very last moment, since StdInPipe and StdOutPipe methods actually create an OS pipe even if the process is not started later. * When a discovery is quitted ensure that the process gets Wait-ed Otherwise, the resources allocated by the process will be leaked. (pipes, zombie process, etc.) * fix i18n
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UPGRADING.mdhas been updated with a migration guide (for breaking changes)This PR fixes two resource leaks pipe in the PluggableDiscovery client, in particular:
discovery.Newcommand: the Process creation was done at object init time and theStdinPipeandStdOutpipemethods actually create an OS pipe even if the process is not started later.Waitmethod to collect the resources used by the zombie process.No