Skip to content

[skip changelog] Add unit test for lib install from git url #1464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 23, 2021

Conversation

silvanocerza
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • What kind of change does this PR introduce?

Add some more unit tests.

  • What is the current behavior?

No unit tests exist for parseGitURL function.

  • What is the new behavior?

parseGitURL is now tested.

Nope.

  • Other information:

Relates to #1462.


See how to contribute

@silvanocerza silvanocerza requested a review from a team September 23, 2021 10:10
@silvanocerza silvanocerza self-assigned this Sep 23, 2021
@silvanocerza silvanocerza force-pushed the scerza/lib-install-git-url branch from c141c4e to 142ffd3 Compare September 23, 2021 10:24
@silvanocerza silvanocerza merged commit 56bfccd into master Sep 23, 2021
@silvanocerza silvanocerza deleted the scerza/lib-install-git-url branch September 23, 2021 12:15
@per1234 per1234 added topic: infrastructure Related to project infrastructure and removed topic: testing labels Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: infrastructure Related to project infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants