Fix builtin discovery tools not being loaded if no platform is installed #1428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silvanocerza
force-pushed
the
scerza/fix-builtin-discoveries
branch
from
d8996ff to
a58f8b5
Compare
cmaglie
approved these changes
Sep 1, 2021
per1234
requested changes
Sep 1, 2021
per1234
approved these changes
Sep 1, 2021
silvanocerza
added a commit
that referenced
this pull request
Sep 1, 2021
…led (#1428) * Fix integration tests detected_boards fixture * Fix builtin discoveries not loaded if no platform is installed * [skip changelog] Add missing breaking change to UPGRADING.md * [skip changelog] Fix board list test running on CI * [skip changelog] Fix UPGRADING.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)Fixes a bug.
If the user has no platform installed and calls
board listno board is ever displayed. This happens because thebuiltindiscoveriesserial-discoveryandmdns-discoveryare never added to the list of available discoveries.board listnow returns a list of connected boards even if no platform is installed.This has been fixed by always adding discoveries from the
builtinpackage even if no platform is installed.titled accordingly?
Nope.
None.
See how to contribute