Skip to content

Fix upload properties not overridden by protocol specific ones #1422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 31, 2021

Conversation

silvanocerza
Copy link
Contributor

@silvanocerza silvanocerza commented Aug 31, 2021

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • What kind of change does this PR introduce?

Fixes a bug with pluggable upload.

  • What is the current behavior?

Board upload properties that are specific to a certain protocol don't override the default property when protocol is specified.

  • What is the new behavior?

Board upload properties that are specific to a certain protocol now override the default one.

Using the following properties:

leonardo.upload.speed=256                                                                                                                           
leonardo.upload.serial.speed=57600                                                                                                                  
leonardo.upload.network.speed=19200 

and the serial protocol would be the same as having the following properties:

leonardo.upload.speed=57600                                                                                                                           
leonardo.upload.serial.speed=57600                                                                                                                  
leonardo.upload.network.speed=19200 

Nope.

  • Other information:

Overrides #1420.


See how to contribute

@silvanocerza silvanocerza added type: bug topic: documentation Related to documentation for the project labels Aug 31, 2021
@silvanocerza silvanocerza self-assigned this Aug 31, 2021
@silvanocerza silvanocerza force-pushed the scerza/fix-upload-properties-expansion branch from 9f281d1 to 42ed0c2 Compare August 31, 2021 12:12
@silvanocerza silvanocerza merged commit 5c5cc78 into master Aug 31, 2021
@silvanocerza silvanocerza deleted the scerza/fix-upload-properties-expansion branch August 31, 2021 13:04
@rsora rsora added type: imperfection Perceived defect in any part of project topic: core labels Sep 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: documentation Related to documentation for the project type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants