Skip to content

Fix board search not returning boards if installed core is not latest version #1410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 25, 2021

Conversation

silvanocerza
Copy link
Contributor

@silvanocerza silvanocerza commented Aug 24, 2021

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • What kind of change does this PR introduce?

Fixes a bug with an existing command and related gRPC function.

  • What is the current behavior?

board search command and related gRPC function don't return board FQBNs belonging to an installed core if it's not the latest version available.

$ arduino-cli core list
ID           Installed Latest Name                                        
arduino:samd 1.8.10    1.8.11 Arduino SAMD Boards (32-bits ARM Cortex-M0+)

$ arduino-cli board search arduino:samd:mkrwifi1010
Board Name FQBN Platform ID 

$ arduino-cli board search mkr wifi 1010
Board Name            FQBN Platform ID  
Arduino MKR WiFi 1010      arduino:samd
  • What is the new behavior?

board search command and related gRPC function now correctly return all FQBNs of installed cores even if it's not the latest version available.

$ arduino-cli core list
ID           Installed Latest Name                                        
arduino:samd 1.8.10    1.8.11 Arduino SAMD Boards (32-bits ARM Cortex-M0+)

$ arduino-cli board search arduino:samd:mkrwifi1010
Board Name            FQBN                     Platform ID  
Arduino MKR WiFi 1010 arduino:samd:mkrwifi1010 arduino:samd 

$ arduino-cli board search mkr wifi 1010           
Board Name            FQBN                     Platform ID  
Arduino MKR WiFi 1010 arduino:samd:mkrwifi1010 arduino:samd 

Nope.

  • Other information:

Partly fixes #1401.


See how to contribute

@silvanocerza silvanocerza merged commit 01c07b6 into master Aug 25, 2021
@silvanocerza silvanocerza deleted the scerza/board-search-old-core branch August 25, 2021 09:02
@rsora rsora added type: imperfection Perceived defect in any part of project topic: gRPC Related to the gRPC interface topic: core topic: CLI Related to the command line interface labels Sep 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: CLI Related to the command line interface topic: gRPC Related to the gRPC interface type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

board search fails with old core and core list not show latest version
3 participants