[skip changelog] Add formatting check to "Check Protocol Buffers" workflow #1391
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…kflow On every push and pull request that affects relevant files, check the protocol buffer files for code formatting inconsistency.
per1234
added
type: enhancement
silvanocerza
approved these changes
Aug 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)Infrastructure enhancement
The CI system checks the protocol buffers will compile and that they don't have any linting violations but it doesn't check for formatting style violations.
On every push and pull request that affects relevant files, the protocol buffer files are checked for compliance with the LLVM code style (default of the ClangFormat formatter tool).
titled accordingly?
No break
Demo workflow run with intentionally introduced formatting violation:
https://github.com/per1234/arduino-cli/runs/3303251386?check_suite_focus=true#step:5:14
(it was trailing whitespace, so not a great diff)
The version of ClangFormat pre-installed in the
ubuntu-latestGitHub Actions runner is used for the check:https://github.com/actions/virtual-environments/blob/main/images/linux/Ubuntu2004-README.md#language-and-runtime