[skip changelog] Make i18n:generate task Windows compatible
#1360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
per1234
added
type: bug
os: windows
silvanocerza
approved these changes
Jul 16, 2021
For the sake of portability of tasks, Task uses `mvdan.cc/sh` to provide an command interpreter that is independent of the environment. While one of the great strengths of Task, this produces unexpected results in some rare cases. This is one of those cases. There is some unusual interaction between `mvdan.cc/sh`, Windows, and running the `rice embed-go` command from the subshell created by the parentheses in this command: ``` $ task i18n:update ←[32mtask: [i18n:update] go run ./i18n/cmd/main.go catalog generate . > ./i18n/data/en.po ←[0m←[32mtask: [i18n:generate] git add -N ./i18n/data ←[0m←[32mtask: [i18n:generate] git diff --exit-code ./i18n/data &> /dev/null || (cd ./i18n && rice embed-go) ←[0merror reading package: go/build: go list github.com/arduino/arduino-cli/i18n: exec: "go": executable file not found in %PATH% ``` It is my belief that the sole purpose of these parentheses was to group the commands and that there is no need to run these commands in a subshell. If so, the change to using braces to group the commands without the creation of a subshell will have no functional effect on the commands, but will allow the task to run on Windows.
per1234
changed the title
i18n:generate task Windows compatiblei18n:generate task Windows compatible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)Bug fix
For the sake of portability of tasks, Task uses
mvdan.cc/shto provide an command interpreter that is independent of the environment. While one of the great strengths of Task, this produces unexpected results in some rare cases. This is one of those cases. There is some unusual interaction betweenmvdan.cc/sh, Windows, and running therice embed-gocommand from the subshell created by the parentheses in this command:(yes, Go is in my
PATH).The task runs on Windows without a strange error.
titled accordingly?
It is my belief that the sole purpose of these parentheses was to group the commands and that there is no need to run these commands in a subshell. If so, the change to using braces to group the commands without the creation of a subshell will have no functional effect on the commands, but will allow the task to run on Windows.