Skip to content

Refactored board details to use pluggable discovery #1332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jul 22, 2021

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Jun 23, 2021

This is a breaking change.

Now board details return the identification properties got from upload_port properties.

Before:

$ arduino-cli board details arduino:samd:mkr1000 | grep Ident -C1

Identification properties: VID:0x2341 PID:0x804e                                                     
                           VID:0x2341 PID:0x004e                                                     
$ arduino-cli board details arduino:samd:mkr1000 --format json|jq .identification_prefs
[
  {
    "usb_id": {
      "vid": "0x2341",
      "pid": "0x804e"
    }
  },
  {
    "usb_id": {
      "vid": "0x2341",
      "pid": "0x004e"
    }
  },
  {
    "usb_id": {
      "vid": "0x2341",
      "pid": "0x824e"
    }
  },
  {
    "usb_id": {
      "vid": "0x2341",
      "pid": "0x024e"
    }
  }
]

After:

$ arduino-cli board details arduino:samd:mkr1000 | grep Ident -C1

Identification properties: vid=0x2341                                                             
                           pid=0x804e                                                             

Identification properties: vid=0x2341                                                             
                           pid=0x004e                                                             

Identification properties: vid=0x2341                                                             
                           pid=0x824e                                                             

Identification properties: vid=0x2341                                                             
                           pid=0x024e                       
$ arduino-cli board details arduino:samd:mkr1000 --format json | jq .identification_properties
[
  {
    "properties": {
      "pid": "0x804e",
      "vid": "0x2341"
    }
  },
  {
    "properties": {
      "pid": "0x004e",
      "vid": "0x2341"
    }
  },
  {
    "properties": {
      "pid": "0x824e",
      "vid": "0x2341"
    }
  },
  {
    "properties": {
      "pid": "0x024e",
      "vid": "0x2341"
    }
  }
]

@cmaglie cmaglie marked this pull request as draft June 23, 2021 14:09
@cmaglie cmaglie force-pushed the pluggable-discovery-5 branch 2 times, most recently from 69beb2d to 90da8c5 Compare June 24, 2021 14:15
@cmaglie cmaglie marked this pull request as ready for review June 24, 2021 15:19
per1234
per1234 previously requested changes Jul 5, 2021
@per1234 per1234 dismissed their stale review July 5, 2021 12:26

Suggested changes have been made. Thanks!

@cmaglie cmaglie force-pushed the pluggable-discovery-5 branch from b680b64 to f5bd03c Compare July 22, 2021 15:05
@cmaglie cmaglie merged commit fc367b7 into arduino:master Jul 22, 2021
@cmaglie cmaglie deleted the pluggable-discovery-5 branch July 22, 2021 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants