Skip to content

Fix upload waiting for port without 1200bps touch #1319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 14, 2021

Conversation

silvanocerza
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • What kind of change does this PR introduce?

Fixes an upload bug.

  • What is the current behavior?

If a platform has set upload.wait_for_upload_port property to true in the boards.txt without setting also upload.use_1200bps_touch to true the CLI waits for the port anyway even if it's not necessary.

  • What is the new behavior?

upload.wait_for_upload_port property now defaults to false and is set only if upload.use_1200bps_touch is true as is documented right now: https://arduino.github.io/arduino-cli/dev/platform-specification/#1200-bps-bootloader-reset

Nope.

  • Other information:

Fixes #1318.


See how to contribute

@silvanocerza silvanocerza added type: bug topic: code Related to content of the project itself labels Jun 14, 2021
@silvanocerza silvanocerza requested a review from a team June 14, 2021 14:09
@silvanocerza silvanocerza self-assigned this Jun 14, 2021
@silvanocerza silvanocerza merged commit d4f31df into master Jun 14, 2021
@silvanocerza silvanocerza deleted the scerza/fix-upload-port-wait branch June 14, 2021 15:37
@per1234 per1234 added the type: imperfection Perceived defect in any part of project label Oct 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please, remove the Monitor-Memorial-Minute
3 participants