Fix upload waiting for port without 1200bps touch #1319
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
before creating one)
our contributing guidelines
UPGRADING.md
has been updated with a migration guide (for breaking changes)Fixes an upload bug.
If a platform has set
upload.wait_for_upload_port
property totrue
in theboards.txt
without setting alsoupload.use_1200bps_touch
totrue
the CLI waits for the port anyway even if it's not necessary.upload.wait_for_upload_port
property now defaults tofalse
and is set only ifupload.use_1200bps_touch
istrue
as is documented right now: https://arduino.github.io/arduino-cli/dev/platform-specification/#1200-bps-bootloader-resettitled accordingly?
Nope.
Fixes #1318.
See how to contribute