Revert "Improved lib detection: check for matching name in library.properties (#1276)" #1290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FWIW, I could see the same issue with esp8266 (current master) and SD library. The wrong one was selected. |
Yes, I confirm. |
cmaglie
approved these changes
May 14, 2021
cmaglie
added a commit
to arduino/arduino-builder
that referenced
this pull request
May 14, 2021
|
Release containing this fix is out. 🎉 https://github.com/arduino/arduino-cli/releases/tag/0.18.3 |
5 tasks
|
For details, see: #1292 |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)Reverts a fix that is causing unforeseen consequences.
Sketch compilation is broken for ESP32 boards when using a library that is installed both in the Sketchbook folder and the core folder.
The reverted commit changed the way libraries are resolved so that the name set in the
library.propertiesis checked to understand which library to included; the libraries included in the ESP32 core have a different name inlibrary.propertiesbecause of legacy reasons from the Java IDE.Compiling a Sketch that includes
OneWire.hwith bothOneWireandOneWirenglibraries installed compiles correctly.Sketch compilation is not broken anymore for ESP32 boards when using a library that is installed both in the Sketchbook folder and the core folder.
Compiling a Sketch that includes
OneWire.hwith bothOneWireandOneWirenglibraries installed doesn't compile anymore.titled accordingly?
No.
This reverts commit
15e81eddb96abfe99fe094db9a433965ea3c7ad7from PR #1276.See how to contribute