Skip to content

Fix network settings uneditable with config command #1288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 13, 2021

Conversation

silvanocerza
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • What kind of change does this PR introduce?

Fixes a bug.

  • What is the current behavior?

Calling arduino-cli config add network.proxy http://<login>:<password>@myproxy.ext:port returns Settings key doesn't exist error.

  • What is the new behavior?

Calling arduino-cli config add network.proxy http://<login>:<password>@myproxy.ext:port sets correctly the network.proxy value.

Nope.

  • Other information:

Fixes #1273


See how to contribute

@silvanocerza silvanocerza requested a review from a team May 13, 2021 09:45
@silvanocerza silvanocerza self-assigned this May 13, 2021
@silvanocerza silvanocerza merged commit b1764d1 into master May 13, 2021
@silvanocerza silvanocerza deleted the scerza/fix-network-configs-validation branch May 13, 2021 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Could not add proxy setting to the configuration file thanks the cli
2 participants