Enhance alphabetic sorting and place deprecated platform at the bottom #1278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…DEPRECATED] to the name
ubidefeo
approved these changes
May 6, 2021
5 tasks
silvanocerza
pushed a commit
that referenced
this pull request
May 10, 2021
#1278) * updated tests * add first draft of sorting * finished/fixed implementation of tests * implementation of sorting function is now correct * removed sorting from the cli (previously added in commands) and add [DEPRECATED] to the name * fixed deprecation notice not being printed if installed.json was already present * fix formatting
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)feature
Sorting is handled in cli and not in commands
Sorting is significantly enhanced and it's made at commands level: platforms are alphabetically sorted even in grpc inferface. Also Deprecated platforms are placed at the bottom.
titled accordingly?
it shouldn't
See how to contribute