Skip to content

[skip changelog] Update proto files build step #1277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 16, 2021
Merged

Conversation

silvanocerza
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • What kind of change does this PR introduce?

Updates how proto file are compiled since with the new version of protoc and protoc-gen-go build process changes.

Nope.

  • Other information:

None.


See how to contribute

@silvanocerza silvanocerza added the topic: code Related to content of the project itself label May 5, 2021
@silvanocerza silvanocerza requested a review from a team May 5, 2021 10:34
@silvanocerza silvanocerza self-assigned this May 5, 2021
@silvanocerza silvanocerza force-pushed the scerza/protoc-fix branch 8 times, most recently from 1b8a0ed to abb5690 Compare May 5, 2021 15:00
@cmaglie cmaglie force-pushed the scerza/protoc-fix branch from abb5690 to 04ee17c Compare June 8, 2021 22:11
@cmaglie cmaglie force-pushed the scerza/protoc-fix branch from 076ed3e to 34e8339 Compare June 9, 2021 16:46
@silvanocerza
Copy link
Contributor Author

Tested the release workflow on my fork, it works, merge this. :shipit:
https://github.com/silvanocerza/arduino-cli/runs/2839394550?check_suite_focus=true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants