Code

Better gRPC error handling#1251

Code

Merged

cmaglie merged 19 commits intoarduino:masterarduino/arduino-cli:masterfrom

cmaglie:proper-errorscmaglie/arduino-cli:proper-errorsCopy head branch name to clipboard

Aug 30, 2021

Commits

Commits on Aug 28, 2021

• Proper gRPC error handling

  cmaglie

  committed
  b7e8ff4

  Copy full SHA for b7e8ff4

• Update gRPC API of board command to return status.Status instead of error

  

  per1234

  authored and

  cmaglie

  committed
  b6522c0

  Copy full SHA for b6522c0

• Update gRPC API of remaining commands to return status.Status instead of error

  

  per1234

  authored and

  cmaglie

  committed
  67c19f2

  Copy full SHA for 67c19f2

• Replace custom error with protobuf message

  Show description for 17652b6
  

  per1234

  authored and

  cmaglie

  committed
  17652b6

  Copy full SHA for 17652b6

• Handle details of any type in `core.PlatformUpgrade()` status

  Show description for c6b72b9
  

  per1234

  authored and

  cmaglie

  committed
  c6b72b9

  Copy full SHA for c6b72b9

• Return nil on program action if an error occurred

  cmaglie

  committed
  4696d07

  Copy full SHA for 4696d07

• Refactoring 'upload' commands

  cmaglie

  committed
  acf791e

  Copy full SHA for acf791e

• Refactoring 'board' commands

  cmaglie

  committed
  4fa1080

  Copy full SHA for 4fa1080

• Refactoring 'compile' commands

  cmaglie

  committed
  ce3f802

  Copy full SHA for ce3f802

• Refactoring 'core' commands

  cmaglie

  committed
  5890cb2

  Copy full SHA for 5890cb2

• Refactoring 'debug' commands

  cmaglie

  committed
  0195111

  Copy full SHA for 0195111

• Refactoring 'lib' commands

  cmaglie

  committed
  1025981

  Copy full SHA for 1025981

• Refactoring 'sketch' commands

  cmaglie

  committed
  1e770ca

  Copy full SHA for 1e770ca

• Refactoring 'commands' commands

  cmaglie

  committed
  677fd55

  Copy full SHA for 677fd55

• updated tests and fixed some error wording

  cmaglie

  committed
  763fcb8

  Copy full SHA for 763fcb8

• fixed go lint warnings

  cmaglie

  committed
  50d17c4

  Copy full SHA for 50d17c4

Commits on Aug 30, 2021

• Apply suggestions from code review

  Show description for 89a61df
  

  cmaglie

  and

  per1234

  committed
  89a61df

  Copy full SHA for 89a61df

• Apply changes from code review

  Show description for 4bcaf9c
  

  cmaglie

  and

  silvanocerza

  committed
  4bcaf9c

  Copy full SHA for 4bcaf9c

• fix i18n

  cmaglie

  committed
  6bf77b9

  Copy full SHA for 6bf77b9