Skip to content

Change core search to update indexes only after 24h from last edit #1237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 29, 2021
Merged

Change core search to update indexes only after 24h from last edit #1237

merged 1 commit into from
Mar 29, 2021

Conversation

silvanocerza
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • What kind of change does this PR introduce?

Changes an existing command.

  • What is the current behavior?

Calling core search always updates the indexes.

  • What is the new behavior?

Calling core search now only updates indexes if one or more of them are older than 24 hours.

It's still possible to force an update by calling core update-index or update.

Nope.

  • Other information:

None.

See how to contribute

@silvanocerza silvanocerza requested a review from a team March 25, 2021 14:58
@silvanocerza silvanocerza self-assigned this Mar 25, 2021
@silvanocerza silvanocerza changed the title Changed core search to update indexes only after 24h Changed core search to update indexes only after 24h Mar 25, 2021
@silvanocerza silvanocerza changed the title Changed core search to update indexes only after 24h Change core search to update indexes only after 24h from last edit Mar 25, 2021
umbynos
umbynos approved these changes Mar 25, 2021
View reviewed changes
Copy link
Contributor

@umbynos umbynos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🏁

@silvanocerza silvanocerza force-pushed the scerza/search-update-index-delay branch from 46f896a to 2dcc462 Compare March 29, 2021 14:12
@silvanocerza silvanocerza merged commit b563cf1 into master Mar 29, 2021
@silvanocerza silvanocerza deleted the scerza/search-update-index-delay branch March 29, 2021 14:58
@per1234 per1234 mentioned this pull request Jan 14, 2022
Closed
@kittaakos kittaakos mentioned this pull request Mar 17, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@umbynos umbynos umbynos approved these changes

Assignees

@silvanocerza silvanocerza

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@silvanocerza @umbynos