Skip to content

Fixed links in docs. Narrowed the amount of files checked by the link-checker. #1233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 24, 2021
Merged

Fixed links in docs. Narrowed the amount of files checked by the link-checker. #1233

merged 3 commits into from
Mar 24, 2021

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Mar 24, 2021

This PR:

  • fix two broken links in the documentation
  • narrows the files tested by the link-check (to avoid checking pytest artifacts or other .md files that are part of the unit tests data)

cmaglie added 3 commits March 24, 2021 12:05
@cmaglie
Fixed internal links to grpc docs
9dd3552
@cmaglie
Only check docs/*.md and various README.md for broken links
508629f 
Otherwise it will check also pytest-generated READMEs and all .md files
included in unit tests data files.
@cmaglie
Round of go mod tidy in docsgen module
014ae93
@cmaglie cmaglie requested review from silvanocerza and per1234 March 24, 2021 11:15
per1234
per1234 approved these changes Mar 24, 2021
View reviewed changes
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Cristian!

@cmaglie cmaglie merged commit 6015f4e into arduino:master Mar 24, 2021
@cmaglie cmaglie deleted the fix_docs_linkcheck branch March 24, 2021 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@per1234 per1234 per1234 approved these changes

@silvanocerza silvanocerza Awaiting requested review from silvanocerza

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cmaglie @per1234