Fix core name not showing if installed.json is not found #1230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ubidefeo
approved these changes
Mar 22, 2021
kittaakos
pushed a commit
to arduino/arduino-ide
that referenced
this pull request
Mar 24, 2021
- New CLI version: `20210324`. - The CLI has the fix for the missing core settings. Ref: arduino/arduino-cli#1230 Closes #245. Signed-off-by: Akos Kitta <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)Fixes a bug when loading installed cores.
core listdoesn't return a core's name if that core folder doesn't contain aninstalled.jsonfile and has been installed via CLI. Manually installed cores have their name correctly shown.This also affects the gRPC interface.
core listnow returns all cores' names even ifinstalled.jsonfile is not found. This also fixes the gRPC interface.titled accordingly?
Nope.
It might happen that
platform.txtandinstalled.jsonhave different names for the same platform, thus it's not guaranted the name will be the same if those two files are not aligned.Fixing those platforms falls on their maintainers.
See how to contribute