Skip to content

Change sketchbook/data paths if IDE is portable #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 9, 2019
Merged

Change sketchbook/data paths if IDE is portable #123

merged 2 commits into from
Jan 9, 2019

Conversation

facchinm
Copy link
Member

@facchinm facchinm commented Jan 9, 2019

No description provided.

@facchinm facchinm requested a review from cmaglie January 9, 2019 08:22
@CLAassistant
Copy link

CLAassistant commented Jan 9, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Jan 9, 2019 •
edited
Loading

Codecov Report

Merging #123 into master will decrease coverage by 0.07%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #123      +/-   ##
==========================================
- Coverage   50.38%   50.31%   -0.08%     
==========================================
  Files          92       92              
  Lines        4118     4124       +6     
==========================================
  Hits         2075     2075              
- Misses       1782     1788       +6     
  Partials      261      261
Impacted Files Coverage Δ
configs/configuration.go 79.16% <ø> (ø) ⬆️
configs/preferences_txt_serializer.go 23.37% <0%> (-1.98%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02ffe3c...b71fd46. Read the comment docs.

@cmaglie cmaglie added this to the next alpha preview milestone Jan 9, 2019
@arduino arduino deleted a comment from ArduinoBot Jan 9, 2019
@ArduinoBot
Copy link
Contributor

✅ Build completed.

⬇️ Linux 64: http://downloads.arduino.cc/PR/arduino-cli/arduino-cli-36-PR123-linux64.tar.bz2

⬇️ Linux 32: http://downloads.arduino.cc/PR/arduino-cli/arduino-cli-36-PR123-linux32.tar.bz2

⬇️ Linux ARM: http://downloads.arduino.cc/PR/arduino-cli/arduino-cli-36-PR123-linuxarm.tar.bz2

⬇️ Windows: http://downloads.arduino.cc/PR/arduino-cli/arduino-cli-36-PR123-windows.zip

⬇️ OSX: http://downloads.arduino.cc/PR/arduino-cli/arduino-cli-36-PR123-osx.zip

ℹ️ To test this build:

  1. Just replace arduino-cli binary with the provided one

@cmaglie cmaglie merged commit 3716816 into arduino:master Jan 9, 2019
@cmaglie cmaglie mentioned this pull request Feb 1, 2019
Merged
per1234 added a commit that referenced this pull request Nov 16, 2020
@per1234
Only run Compile Examples workflow when relevant files are modified (#…
a9dbf5c 
…123)

Running the Compile Examples GitHub Actions workflow is only necessary when files under examples/ or src/, or the workflow configuration itself are modified. For any other changes, the workflow run only slows down the CI results and causes unnecessary comments from the report-size-deltas workflow.
per1234 added a commit that referenced this pull request Aug 9, 2021
@per1234
Merge pull request #123 from arduino/per1234/install-script
2573f87 
Add release installation support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmaglie cmaglie Awaiting requested review from cmaglie

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.3.4-alpha.preview
Development

Successfully merging this pull request may close these issues.
4 participants
@facchinm @CLAassistant @ArduinoBot @cmaglie