[skip changelog] Fix release process #1163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current release process uses git to get the tag at the current commit. It might happen that are are multiple tags when calling that command, in cases the rc and the final release are done on the same commit, that would make the build process to fail. This fixes that issue by taking only one tag.
rsora
approved these changes
Feb 1, 2021
silvanocerza
added a commit
that referenced
this pull request
Feb 1, 2021
The current release process uses git to get the tag at the current commit. It might happen that are are multiple tags when calling that command, in cases the rc and the final release are done on the same commit, that would make the build process to fail. This fixes that issue by taking only one tag.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current release process uses git to get the tag at the current
commit. It might happen that are are multiple tags when calling that
command, in cases the rc and the final release are done on the same
commit, that would make the build process to fail.
This fixes that issue by taking only one tag.