Skip to content

[skip changelog] Improve wording of FAQ re: boards w/o dedicated VID/PID #1097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 10, 2020
Merged

[skip changelog] Improve wording of FAQ re: boards w/o dedicated VID/PID #1097

merged 2 commits into from
Dec 10, 2020

Conversation

per1234
Copy link
Contributor

@per1234 per1234 commented Dec 3, 2020

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • What kind of change does this PR introduce?

Docs update.

  • What is the current behavior?

Despite the Arduino Nano being the sole active official Arduino board without a custom VID/PID, it is not mentioned in the FAQ item about this type of board.

  • What is the new behavior?

The classic Nano is explicitely mentioned in the FAQ item and the wording is slightly improved.

No

  • Other information:

Related:

Some minor wording improvements for readability/correct terminology.
The classic Nano is the sole active official board without a custom VID/PID, so it's especially important to mention it
in this FAQ.
@per1234 per1234 added the topic: documentation Related to documentation for the project label Dec 3, 2020
@per1234 per1234 requested a review from ubidefeo December 9, 2020 02:33
Copy link

@ubidefeo ubidefeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great rewording.
Thank you for adding the legacy Nano
LGTM

@per1234 per1234 merged commit bf7a319 into arduino:master Dec 10, 2020
@per1234 per1234 deleted the mention-nano-in-board-list-faq branch December 10, 2020 10:34
@per1234 per1234 self-assigned this Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: documentation Related to documentation for the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants