Skip to content

[skip changelog] Add workflow to check for problems with certificates #1071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 13, 2020
Merged

[skip changelog] Add workflow to check for problems with certificates #1071

merged 1 commit into from
Nov 13, 2020

Conversation

per1234
Copy link
Contributor

@per1234 per1234 commented Nov 13, 2020

If the certificates fail verification, a notification will be posted on the #team_tooling Slack channel.

If the certificates expire in less than 30 days, a notification will be posted on the #team_tooling Slack channel.

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce?

Feature

  • What is the current behavior?

It's possible that the macOS code signing certificate could expire before the maintainers notice that it needs to be renewed.

  • What is the new behavior?

A scheduled CI workflow checks the CI certificate for validity and pending expiration. If the certificate is found to be invalid or will expire in less than 30 days, a notification is posted to a Slack channel.
slack1
slack2
(above notification is from a simulated pending certificate expiration, it would normally only occur if there was <30 days)

The workflow is configured in a way that allows it to support checking additional certificates.

  • Does this PR introduce a breaking change?

No.

  • Other information:

Demonstration workflow runs:

@per1234 per1234 changed the title Add workflow to check for problems with certificates [skip changelog] Add workflow to check for problems with certificates Nov 13, 2020
If the certificates fail verification, a notification will be posted on the #team_tooling Slack channel.

If the certificates expire in less than 30 days, a notification will be posted on the #team_tooling Slack channel.
Copy link
Contributor

@rsora rsora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes!

@per1234 per1234 merged commit 1855b53 into arduino:master Nov 13, 2020
@per1234 per1234 deleted the certificate-check branch November 13, 2020 10:16
@per1234 per1234 self-assigned this Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants