Skip to content

[skip changelog] Fix sketch tests on Windows #1061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 9, 2020
Merged

[skip changelog] Fix sketch tests on Windows #1061

merged 1 commit into from
Nov 9, 2020

Conversation

silvanocerza
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce?

Fixes sketch tests.

  • What is the current behavior?

Certain sketch tests fail on Window and are skipped when on CI.

  • What is the new behavior?

Sketch tests are all run on CI and Windows.

  • Does this PR introduce a breaking change?

No

  • Other information:

None.

See how to contribute

@silvanocerza silvanocerza requested review from cmaglie and rsora November 9, 2020 14:37
@silvanocerza silvanocerza self-assigned this Nov 9, 2020
@silvanocerza silvanocerza force-pushed the scerza/sketch-tests-windows-fix branch from bcf9061 to 4c33bf8 Compare November 9, 2020 14:38
rsora
rsora approved these changes Nov 9, 2020
View reviewed changes
Copy link
Contributor

@rsora rsora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@silvanocerza silvanocerza merged commit ff3302f into master Nov 9, 2020
@silvanocerza silvanocerza deleted the scerza/sketch-tests-windows-fix branch November 9, 2020 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsora rsora rsora approved these changes

@cmaglie cmaglie Awaiting requested review from cmaglie

Assignees

@silvanocerza silvanocerza

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@silvanocerza @rsora