Skip to content

Fixed discovery tests timeouts #1057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 3, 2020
Merged

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Nov 3, 2020

Running command through go run ... will introduce artificial delays and this affects the test on discoveries because it relies on timeouts.

Now the test program is built for real instead of being run through go run ...

Running command through "go run ..." will introduce artificial delayes.
@cmaglie cmaglie requested a review from silvanocerza November 3, 2020 13:47
@cmaglie cmaglie self-assigned this Nov 3, 2020
@cmaglie cmaglie merged commit c81dfc4 into arduino:master Nov 3, 2020
@cmaglie cmaglie deleted the fix_discovery_tests branch November 3, 2020 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants