Skip to content

Core and lib search command now update indexes first #1043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 27, 2020
Merged

Core and lib search command now update indexes first #1043

merged 1 commit into from
Oct 27, 2020

Conversation

silvanocerza
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce?
    Enhances existing commands.
  • What is the current behavior?
    Calling core search or lib search doesn't update indexes before searching.
  • What is the new behavior?
    Calling core search or lib search now updates indexes before searching.
  • Does this PR introduce a breaking change?
    No.

See how to contribute

@silvanocerza silvanocerza self-assigned this Oct 21, 2020
@silvanocerza silvanocerza force-pushed the scerza/auto-index-update branch from 74e84f7 to 218e9c8 Compare October 21, 2020 15:31
@silvanocerza silvanocerza force-pushed the scerza/auto-index-update branch from 218e9c8 to b6ce0d5 Compare October 21, 2020 15:55
endorama
endorama approved these changes Oct 26, 2020
View reviewed changes
Copy link
Contributor

@endorama endorama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just performed a test searching for ArduinoIoTCloud (latest is 0.11.2, my "local" latest is 0.11.1) and it worked like a charm!
🤟

@ubidefeo
Copy link

@endorama are you happy we put it in the sprint? 😀

ubidefeo
ubidefeo approved these changes Oct 27, 2020
View reviewed changes
Copy link

@ubidefeo ubidefeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

successfully tested
no objections

@silvanocerza silvanocerza merged commit bf6bb1e into master Oct 27, 2020
@silvanocerza silvanocerza deleted the scerza/auto-index-update branch October 27, 2020 14:07
@per1234 per1234 mentioned this pull request Jan 14, 2022
Closed
@kittaakos kittaakos mentioned this pull request Mar 17, 2022
Closed
@kittaakos kittaakos mentioned this pull request Jun 14, 2022
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@endorama endorama endorama approved these changes

@ubidefeo ubidefeo ubidefeo approved these changes

@cmaglie cmaglie Awaiting requested review from cmaglie

Assignees

@silvanocerza silvanocerza

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inform user when the indexes are outdated
3 participants
@silvanocerza @ubidefeo @endorama