Skip to content

Various fix and improvements to "upload" #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 7, 2019

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Dec 24, 2018

  • Added tests for upload command (parsing only)
  • Added check for missing "recipe.output.tmp_file" property
  • Fixed check for upload.tool existence (it should not check for tool existence but just for the referenced platform, if specified). Should help to fix Upload tool 'avrdude' not found.  #83

Not strictly related to upload, but useful to make tests run more efficiently:

  • Downloaded archives are kept in a temporary folder and reused (so they are downloaded only once and not many times)

@arduino arduino deleted a comment from ArduinoBot Dec 24, 2018
@ArduinoBot
Copy link
Contributor

✅ Build completed.

⬇️ Linux 64: http://downloads.arduino.cc/PR/arduino-cli/arduino-cli-30-PR103-linux64.tar.bz2

⬇️ Linux 32: http://downloads.arduino.cc/PR/arduino-cli/arduino-cli-30-PR103-linux32.tar.bz2

⬇️ Linux ARM: http://downloads.arduino.cc/PR/arduino-cli/arduino-cli-30-PR103-linuxarm.tar.bz2

⬇️ Windows: http://downloads.arduino.cc/PR/arduino-cli/arduino-cli-30-PR103-windows.zip

⬇️ OSX: http://downloads.arduino.cc/PR/arduino-cli/arduino-cli-30-PR103-osx.zip

ℹ️ To test this build:

  1. Just replace arduino-cli binary with the provided one

@codecov
Copy link

codecov bot commented Dec 26, 2018

Codecov Report

Merging #103 into master will increase coverage by 2.61%.
The diff coverage is 37.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #103      +/-   ##
==========================================
+ Coverage   47.77%   50.38%   +2.61%     
==========================================
  Files          92       92              
  Lines        4113     4118       +5     
==========================================
+ Hits         1965     2075     +110     
+ Misses       1911     1782     -129     
- Partials      237      261      +24
Impacted Files Coverage Δ
configs/configuration.go 79.16% <100%> (-2.66%) ⬇️
configs/env_vars_serializer.go 77.77% <100%> (+6.34%) ⬆️
configs/yaml_serializer.go 23.72% <16.66%> (-0.8%) ⬇️
commands/upload/upload.go 45.12% <31.81%> (+33.12%) ⬆️
arduino/cores/packagemanager/package_manager.go 50.28% <0%> (+2.82%) ⬆️
commands/commands.go 53.84% <0%> (+4.61%) ⬆️
arduino/cores/cores.go 78.31% <0%> (+4.81%) ⬆️
arduino/cores/tools.go 64.55% <0%> (+6.32%) ⬆️
configs/hardware_directories.go 57.89% <0%> (+10.52%) ⬆️
executils/executils.go 17.14% <0%> (+17.14%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3819f27...e1697dd. Read the comment docs.

@cmaglie cmaglie merged commit 06d5bd3 into arduino:master Jan 7, 2019
@cmaglie cmaglie added this to the next alpha preview milestone Jan 7, 2019
@cmaglie cmaglie deleted the upload-uncond-test branch January 7, 2019 16:10
per1234 added a commit that referenced this pull request Aug 9, 2021
Use appropriate check result value when determined not relevant
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upload tool 'avrdude' not found.
2 participants