Skip to content

Fix default config file not found #1021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

silvanocerza
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce?
    Fixes default config file never found.
  • What is the current behavior?
    Default config file is never found by the CLI.
  • What is the new behavior?
    Default config file is now found correctly.
  • Does this PR introduce a breaking change?
    No.

See how to contribute

@rsora
Copy link
Contributor

rsora commented Oct 9, 2020

@silvanocerza is it possible to create a test (unit or integ) to catch this regression?
As we will work more on the config management in the next weeks it would be nice to enhance our safeguards in this area WDYT?

@silvanocerza
Copy link
Contributor Author

Already solved by #1027, closing.

@silvanocerza silvanocerza deleted the scerza/config-fix branch October 15, 2020 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ Nightly Build Regression ] - Arduino CLI will not use the default configuration .yaml file
2 participants