Skip to content

Temporary fix for incorrect merge sketch+bootloader #1017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 3, 2020
Merged

Temporary fix for incorrect merge sketch+bootloader #1017

merged 1 commit into from
Nov 3, 2020

Conversation

facchinm
Copy link
Member

@facchinm facchinm commented Oct 8, 2020

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce?

This patch includes facchinm/gohex@be2a6be , which allows supporting .hex sections bigger than 64KB.

Should fix #2842 and #1009

  • What is the current behavior?

See linked issues

  • What is the new behavior?

The produced with_bootloader.hex and with_bootloader.bin can be flashed and are functional

  • Does this PR introduce a breaking change?
  • Other information:

See how to contribute

@facchinm
Copy link
Member Author

Will be superseded when marcinbor85/gohex#2 is merged

@cmaglie cmaglie merged commit 17d24eb into arduino:master Nov 3, 2020
@JAndrassy JAndrassy mentioned this pull request Nov 17, 2020
Closed
@facchinm facchinm mentioned this pull request Dec 10, 2020
Closed
@per1234 per1234 added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project topic: build-process Related to the sketch build process labels Feb 20, 2025
@per1234 per1234 mentioned this pull request Feb 20, 2025
Closed
@per1234 per1234 added topic: infrastructure Related to project infrastructure and removed topic: code Related to content of the project itself labels Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmaglie cmaglie cmaglie approved these changes

Assignees
No one assigned
Labels
topic: build-process Related to the sketch build process topic: infrastructure Related to project infrastructure type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

.hex file with bootloader is incorrect for ATmega2560 targets (Arduino Mega2560)
3 participants
@facchinm @cmaglie @per1234