Skip to content

Don't bail out if trying to upload external binary #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 19, 2018
Merged

Don't bail out if trying to upload external binary #101

merged 1 commit into from
Dec 19, 2018

Conversation

facchinm
Copy link
Member

No functional modification for standard flow (compile+upload without -i flag)

@CLAassistant
Copy link

CLAassistant commented Dec 14, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@facchinm @cmaglie
Don't bail out if trying to upload external binary
592bbdc 
No functional modification for standard flow (compile+upload without -i flag)
@cmaglie cmaglie force-pushed the upload_unconditionally branch from 3cd797a to 592bbdc Compare December 19, 2018 15:17
@arduino arduino deleted a comment from codecov bot Dec 19, 2018
@arduino arduino deleted a comment from ArduinoBot Dec 19, 2018
@ArduinoBot
Copy link
Contributor

✅ Build completed.

⬇️ Linux 64: http://downloads.arduino.cc/PR/arduino-cli/arduino-cli-28-PR101-linux64.tar.bz2

⬇️ Linux 32: http://downloads.arduino.cc/PR/arduino-cli/arduino-cli-28-PR101-linux32.tar.bz2

⬇️ Linux ARM: http://downloads.arduino.cc/PR/arduino-cli/arduino-cli-28-PR101-linuxarm.tar.bz2

⬇️ Windows: http://downloads.arduino.cc/PR/arduino-cli/arduino-cli-28-PR101-windows.zip

⬇️ OSX: http://downloads.arduino.cc/PR/arduino-cli/arduino-cli-28-PR101-osx.zip

ℹ️ To test this build:

  1. Just replace arduino-cli binary with the provided one

@codecov
Copy link

codecov bot commented Dec 19, 2018 •
edited
Loading

Codecov Report

Merging #101 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #101   +/-   ##
=======================================
  Coverage   47.83%   47.83%           
=======================================
  Files          92       92           
  Lines        4112     4112           
=======================================
  Hits         1967     1967           
  Misses       1908     1908           
  Partials      237      237
Impacted Files Coverage Δ
commands/upload/upload.go 12.06% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09f8600...592bbdc. Read the comment docs.

@cmaglie cmaglie merged commit 592bbdc into arduino:master Dec 19, 2018
@cmaglie cmaglie added this to the next alpha preview milestone Dec 19, 2018
per1234 pushed a commit that referenced this pull request Nov 16, 2020
@aentinger
Adding MKR NB 1500 as built target for CI (#101)
18d2b93 
* Adding MKR NB 1500 as built target for CI

* Adding support for MKR NB 1500 to 'ArduinoIoTCloud_LED_switch'

* Adding support for MKR NB 1500 to 'ArduinoIoTCloud_Travis_CI'

* Readding MKR WAN 1300/1310 to error message
per1234 added a commit that referenced this pull request Aug 9, 2021
@per1234
Merge pull request #101 from arduino/per1234/integration-tests
88632d3 
Add integration tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.3.4-alpha.preview
Development

Successfully merging this pull request may close these issues.
4 participants
@facchinm @CLAassistant @ArduinoBot @cmaglie