Skip to content

[feature request] add a way to add ldflags even without precompiled libraries #754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
nerdralph opened this issue Jun 18, 2020 · 0 comments
Open

[feature request] add a way to add ldflags even without precompiled libraries #754

nerdralph opened this issue Jun 18, 2020 · 0 comments
Assignees
@cmaglie
Labels
topic: build-process Related to the sketch build process topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project

Comments

@nerdralph
Copy link

Bug Report

library.properties ldflags is ignored unless precompiled=true

Current behavior

After failing to get ldflags to work, I checked the source and found it is only used with precompiled libraries.

arduino-cli/legacy/builder/phases/libraries_builder.go

Line 137 in 1c7920f

if library.Precompiled {

Expected behavior

ldflags, when specified, should always get added to the link line.

Environment

arduino-cli.exe Version: 0.10.0 Commit: ec5c3ed
Win7e/mingw32

Additional context

I'm writing a bootloader library, and was trying to use the --section-start linker option.
While reviewing the code, I also noticed there is an undocumented precompiled=full option for library.properties.
@per1234 per1234 mentioned this issue Jul 13, 2020
Merged
4 tasks
@per1234 per1234 reopened this Mar 30, 2021
@per1234 per1234 added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Mar 31, 2022
@umbynos umbynos added the topic: build-process Related to the sketch build process label Oct 20, 2022
@umbynos umbynos changed the title ldflags only works with precompiled [feature request] add a way to add ldflags even without precompiled libraries Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cmaglie cmaglie

Labels
topic: build-process Related to the sketch build process topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@cmaglie @nerdralph @per1234 @umbynos