Skip to content

core search should support platform ID match #612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kittaakos opened this issue Mar 10, 2020 · 1 comment · Fixed by #615
Closed

core search should support platform ID match #612

kittaakos opened this issue Mar 10, 2020 · 1 comment · Fixed by #615

Comments

@kittaakos
Copy link
Contributor

kittaakos commented Mar 10, 2020

The current implementation of the core search checks matches based on

Would it be possible to search by the platform ID?

string ID = 1;

Current behavior:

akos.kitta@Akoss-MacBook-Pro arduino-cli % ./arduino-cli core search
ID                   Version   Name                                             
Arrow:samd           2.1.0     Arrow Boards                                     
Intel:arc32          2.0.4     Intel Curie Boards                               
Intel:i586           1.6.7+1.0 Intel i586 Boards                                
Intel:i686           1.6.7+1.0 Intel i686 Boards                                
Microsoft:win10      1.1.2     Windows 10 Iot Core                              
arduino:avr          1.8.2     Arduino AVR Boards                               
arduino:mbed         1.1.4     Arduino nRF528x Boards (Mbed OS)                 
arduino:megaavr      1.8.5     Arduino megaAVR Boards                           
arduino:nrf52        1.0.2     Arduino nRF52 Boards                             
arduino:sam          1.6.12    Arduino SAM Boards (32-bits ARM Cortex-M3)       
arduino:samd         1.8.5     Arduino SAMD Boards (32-bits ARM Cortex-M0+)     
arduino:samd_beta    1.6.25    Arduino SAMD Beta Boards (32-bits ARM Cortex-M0+)
atmel-avr-xminis:avr 0.6.0     Atmel AVR Xplained-minis                         
emoro:avr            3.2.2     EMORO 2560                                       
industruino:samd     1.0.1     Industruino SAMD Boards (32-bits ARM Cortex-M0+) 
littleBits:avr       1.0.0     littleBits Arduino AVR Modules                   

akos.kitta@Akoss-MacBook-Pro arduino-cli % ./arduino-cli core search "arduino:sam"
No platforms matching your search.

Expected behavior:

akos.kitta@Akoss-MacBook-Pro arduino-cli % ./arduino-cli core search "arduino:sam"
ID          Version Name                                      
arduino:sam 1.6.12  Arduino SAM Boards (32-bits ARM Cortex-M3)

Workaround:
I run a wildcard query and filter the results by the platform ID.

Arduino CLI version:

  • I built one from the sources: 8483cb2,
  • OS: macOS 10.15.3
kittaakos pushed a commit to kittaakos/arduino-cli that referenced this issue Mar 12, 2020
@kittaakos
Copy link
Contributor Author

PR: #615

kittaakos pushed a commit to kittaakos/arduino-cli that referenced this issue Mar 12, 2020
When matching against a Platform#ID, the match must be a
case-insensitive exact match.

Closes arduino#612.

Signed-off-by: Akos Kitta <[email protected]>
rsora pushed a commit that referenced this issue Mar 20, 2020
When matching against a Platform#ID, the match must be a
case-insensitive exact match.

Closes #612.

Signed-off-by: Akos Kitta <[email protected]>
vinay-lanka pushed a commit to vinay-lanka/arduino-cli that referenced this issue Mar 23, 2020
When matching against a Platform#ID, the match must be a
case-insensitive exact match.

Closes arduino#612.

Signed-off-by: Akos Kitta <[email protected]>

update compile --build-path to support both relative and absolute flags
vinay-lanka pushed a commit to vinay-lanka/arduino-cli that referenced this issue Mar 26, 2020
When matching against a Platform#ID, the match must be a
case-insensitive exact match.

Closes arduino#612.

Signed-off-by: Akos Kitta <[email protected]>

update compile --build-path to support both relative and absolute flags
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant