Skip to content

Null pointer if target .ino is a folder #358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
facchinm opened this issue Aug 26, 2019 · 6 comments · Fixed by #421
Closed

Null pointer if target .ino is a folder #358

facchinm opened this issue Aug 26, 2019 · 6 comments · Fixed by #421
Milestone
0.7.0

Comments

@facchinm
Copy link
Member

Bug Report

Current behavior

./arduino-cli --debug compile -b anything:something:meh ~/Arduino/Blink crashes with null pointer dereference if ~/Arduino/Blink contains a folder called Blink.ino

Expected behavior

Malformed ino files should be recognized and skipped.

Environment

  • CLI version (output of arduino-cli version): nightly-4-gcb3c79b
  • OS and platform: linux x86_64

Additional context
@masci masci added the kind/bug label Aug 30, 2019
@cmaglie cmaglie added this to the 0.6.0 milestone Sep 12, 2019
This was referenced Sep 23, 2019
Closed
Merged
@shade34321
Copy link

Has this already been worked on? If not I'd like to try it.

@masci
Copy link
Contributor

masci commented Sep 26, 2019

@shade34321 all yours!

@masci masci assigned masci and unassigned masci Sep 26, 2019
@shade34321
Copy link

Sweet, Thanks!

@masci
Copy link
Contributor

masci commented Oct 1, 2019 •
edited
Loading

@shade34321 FYI it seems #421 indirectly fixes this issue
[edit] fixed PR number

@masci
Copy link
Contributor

masci commented Oct 1, 2019

@d-a-v 421, autocompletion tricked me :)

@shade34321
Copy link

Oh ok. Guess I won't need to work on this. I'll see if I can find something else easy to work on. Thanks!

@rsora rsora modified the milestones: 0.6.0, 0.7.0 Oct 21, 2019
rsora pushed a commit that referenced this issue Oct 24, 2019
add testcases to replicate #424 and #358
ef2f209
rsora pushed a commit that referenced this issue Oct 29, 2019
add testcases to cover #358 (Symbolic link as sketch directory) and #424
ebca955 
 (folder with .ino extension)
@rsora rsora mentioned this issue Oct 29, 2019
Merged
rsora pushed a commit that referenced this issue Oct 30, 2019
Add unit and integration testing for the sketch recursive load functi…
292277f 
…onality (#462)

* add testcases to cover #358 (Symbolic link as sketch directory) and #424 (folder with .ino extension)

* add test to check error throw on symlink loop detection

* create symlink via test code to ensure cross platform creation

* fixed assert to make the check cross platform

* fixed all symlink check asserts to make the check cross platform

* nitpicking
@silvanocerza silvanocerza mentioned this issue Jul 9, 2021
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.7.0
Development

Successfully merging a pull request may close this issue.

Use a local Walk function d-a-v/arduino-cli
5 participants
@masci @cmaglie @shade34321 @facchinm @rsora