Skip to content

upload -t(--verify) enables "Verbose" instead of "Verify" #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cjsieh opened this issue Sep 4, 2018 · 3 comments
Closed

upload -t(--verify) enables "Verbose" instead of "Verify" #31

cjsieh opened this issue Sep 4, 2018 · 3 comments

Comments

@cjsieh
Copy link

cjsieh commented Sep 4, 2018

$ go/bin/arduino-cli-0.2.1-alpha.preview-linux64 upload -t --port /dev/ttyUSB0 -b arduino:avr:nano:cpu=atmega328 Blink

avrdude: Version 6.3, compiled on Jan 17 2017 at 11:00:16

avrdude: 928 bytes of flash

Above shows --verbose and NO --verify

$ ./arduino-cli upload -t -v --port /dev/ttyUSB0 -b arduino:avr:nano:cpu=atmega328 ~/Blink
avrdude: Version 6.3, compiled on Jan 17 2017 at 11:00:16

avrdude: 928 bytes of flash written
avrdude: verifying flash memory against /home/siehputz/Blink/Blink.arduino.avr.nano.cpu=atmega328.hex:
avrdude: load data flash data from input file /home/siehputz/Blink/Blink.arduino.avr.nano.cpu=atmega328.hex:
avrdude: input file /home/siehputz/Blink/Blink.arduino.avr.nano.cpu=atmega328.hex contains 928 bytes
avrdude: reading on-chip flash data:

Reading | ################################################## | 100% 0.13s

avrdude: verifying ...
avrdude: 928 bytes of flash verified


This upload.go was patched with

--- ../../../../Downloads/upload.go 2018-09-04 10:49:25.040860707 -0500
+++ arduino-cli/commands/upload/upload.go 2018-09-02 18:39:56.060296516 -0500
@@ -49,7 +49,7 @@
"Fully Qualified Board Name, e.g.: arduino:avr:uno")
uploadCommand.Flags().StringVarP(&flags.port, "port", "p", "",
"Upload port, e.g.: COM10 or /dev/ttyACM0")

  • uploadCommand.Flags().BoolVarP(&flags.verbose, "verify", "t", false,
  • uploadCommand.Flags().BoolVarP(&flags.verify, "verify", "t", false,
    "Verify uploaded binary after the upload.")
    uploadCommand.Flags().BoolVarP(&flags.verbose, "verbose", "v", false,
    "Optional, turns on verbose mode.")

@cjsieh
Copy link
Author

cjsieh commented Sep 4, 2018

The example of it broken did not seem to show up. Here it is again.

$ go/bin/arduino-cli-0.2.1-alpha.preview-linux64 upload -t --port /dev/ttyUSB0 -b arduino:avr:nano:cpu=atmega328 Blink

avrdude: Version 6.3, compiled on Jan 17 2017 at 11:00:16

.. snipped

avrdude: writing flash (928 bytes):

Writing | ################################################## | 100% 0.16s

avrdude: 928 bytes of flash written

@cjsieh
Copy link
Author

cjsieh commented Sep 4, 2018

Patch without HTML screwing it up

--- ../../../../Downloads/upload.go	2018-09-04 10:49:25.040860707 -0500
+++ arduino-cli/commands/upload/upload.go	2018-09-02 18:39:56.060296516 -0500
@@ -49,7 +49,7 @@
 		"Fully Qualified Board Name, e.g.: arduino:avr:uno")
 	uploadCommand.Flags().StringVarP(&flags.port, "port", "p", "",
 		"Upload port, e.g.: COM10 or /dev/ttyACM0")
-	uploadCommand.Flags().BoolVarP(&flags.verbose, "verify", "t", false,
+	uploadCommand.Flags().BoolVarP(&flags.verify, "verify", "t", false,
 		"Verify uploaded binary after the upload.")
 	uploadCommand.Flags().BoolVarP(&flags.verbose, "verbose", "v", false,
 		"Optional, turns on verbose mode.")

@cmaglie
Copy link
Member

cmaglie commented Sep 14, 2018

Thank you!

@cmaglie cmaglie added this to the 0.2.2-alpha.preview milestone Sep 14, 2018
@cmaglie cmaglie added the bug label Sep 14, 2018
mastrolinux pushed a commit that referenced this issue Jul 16, 2019
per1234 pushed a commit that referenced this issue Nov 16, 2020
per1234 pushed a commit that referenced this issue Nov 16, 2020
Add GSM and Ethernet conn_manager + add fallback UDP based getTime()
per1234 added a commit that referenced this issue Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants