Skip to content

The config dump commands doesn't print default values #2637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
3 tasks done
alessio-perugini opened this issue Jun 14, 2024 · 2 comments
Closed
3 tasks done

The config dump commands doesn't print default values #2637

alessio-perugini opened this issue Jun 14, 2024 · 2 comments
Assignees
Labels
conclusion: invalid Issue/PR not valid topic: CLI Related to the command line interface topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project

Comments

@alessio-perugini
Copy link
Contributor

Describe the problem

We have received a PR in arduino/arduino-language-server#188 that wanted to address a nil pointer problem.
After a further investigation, we found out that the arduino-cli 1.0.0 introduced a regression.

The config dump only prints values present in the arduino-cli.yaml.

Here the diff: arduino/arduino-language-server#188 (comment)

To reproduce

arduino-cli config dump --json with the 1.0.0 release

Expected behavior

It should also print the default values for keys that are not present in the config file

Arduino CLI version

1.0.0

Operating system

Linux

Operating system version

23.10

Additional context

No response

Issue checklist

  • I searched for previous reports in the issue tracker
  • I verified the problem still occurs when using the nightly build
  • My report contains all necessary details
@alessio-perugini alessio-perugini added the type: imperfection Perceived defect in any part of project label Jun 14, 2024
@cmaglie
Copy link
Member

cmaglie commented Jun 14, 2024

This is the desired behavior, you can use config get .... if you need a specific value.

I've pushed a fix in the language server repo arduino/arduino-language-server#189

@cmaglie cmaglie closed this as completed Jun 14, 2024
@cmaglie cmaglie added the conclusion: invalid Issue/PR not valid label Jun 14, 2024
@per1234 per1234 added topic: CLI Related to the command line interface topic: code Related to content of the project itself labels Jun 14, 2024
@per1234
Copy link
Contributor

per1234 commented Jul 29, 2024

The regression point was at 1fddba7.

This should have been documented in the Upgrading doc at the time the significant breaking API change was made. I submitted a PR for that: #2676

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conclusion: invalid Issue/PR not valid topic: CLI Related to the command line interface topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Development

No branches or pull requests

3 participants