Skip to content

Enhance debug -I not encoding information in property name #2395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
umbynos opened this issue Oct 31, 2023 · 0 comments · Fixed by #2396
Closed

Enhance debug -I not encoding information in property name #2395

umbynos opened this issue Oct 31, 2023 · 0 comments · Fixed by #2396
Assignees
Labels
type: enhancement Proposed improvement

Comments

@umbynos
Copy link
Contributor

umbynos commented Oct 31, 2023

Current JSON output:

"cortex-debug_custom_configuration": {         <===
    "postAttachCommands": [
        ...
    ],
    "overrideRestartCommands": [
        ...
    ]
  },

New JSON output will be:

"custom_configuration": {
    "cortex-debug": {              <===
      "postAttachCommands": [
        ...
      ],
      "overrideRestartCommands": [
        ...
      ]
    }
  },

Separating cortex-debug_custom_configuration into custom_configuration.cortex-debug provides a better JSON structure. Not putting information inside the property name. This gives also a more robust system to platform dev allowing them to specify other custom_configuration object if they need to.

@umbynos umbynos added this to the Arduino CLI v0.35.0 milestone Oct 31, 2023
@umbynos umbynos added the type: enhancement Proposed improvement label Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants