Skip to content

Different import zip file behaviour (gRPC vs IDE). #1439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
4ntoine opened this issue Sep 9, 2021 · 2 comments
Closed

Different import zip file behaviour (gRPC vs IDE). #1439

4ntoine opened this issue Sep 9, 2021 · 2 comments
Assignees
Labels
conclusion: duplicate Has already been submitted type: imperfection Perceived defect in any part of project

Comments

@4ntoine
Copy link
Contributor

4ntoine commented Sep 9, 2021

Bug Report

Current behavior

Download repo as a zip from https://github.com/phyphox/phyphox-arduino and use downloaded file ("phyphox-arduino-master.zip") as zipLibraryInstall path.

Calling zipLibraryInstall() fails with "Failed to install the li: gRPC Error (code: 13, codeName: INTERNAL, message: Library install failed: library is not valid: missing header file "phyphox-arduino-master.h", details: [], rawResponse: null, trailers: {})".

I've checked i can import exactly the same file in IDE.

Expected behavior

The lib is imported.

Environment

  • CLI version (output of arduino-cli version): 0.19.0
  • OS and platform: macOS 10.14.6

Additional context

@per1234
Copy link
Contributor

per1234 commented Sep 9, 2021

Hi @4ntoine. Thanks for taking the time to submit this issue.

I see we already have a prior issue report about this at #1306.

It's best to have only a single issue per subject so we can consolidate all relevant discussion to one place, so I'll go ahead and close this in favor of the other.

If you end up with additional information to share, feel free to comment in the other thread.

@per1234 per1234 closed this as completed Sep 9, 2021
@per1234 per1234 added conclusion: duplicate Has already been submitted type: bug labels Sep 9, 2021
@4ntoine
Copy link
Contributor Author

4ntoine commented Sep 9, 2021 via email

@rsora rsora added the type: imperfection Perceived defect in any part of project label Sep 22, 2021
@per1234 per1234 self-assigned this Nov 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conclusion: duplicate Has already been submitted type: imperfection Perceived defect in any part of project
Projects
None yet
Development

No branches or pull requests

3 participants