-
-
Notifications
You must be signed in to change notification settings - Fork 398
Crash when requesting platforms list over gRPC #1434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
However the following cli request succeeds:
|
Hi @4ntoine. Thanks so much for your report. I see you're using a significantly outdated version of Arduino CLI. Please try again with the latest nightly build and then post an update with your results: Note also that there have been some recent breaking changes to the gRPC API: |
@per1234 This is the most recent version that is available via |
Same for
|
Same for nightly build:
|
I've noted now (for 0.19.0 and later) it fails during the |
Yup, i've regenerated the source code (for
I can provide access to the repo if necessary. |
jic (trying "0.19.0" with test):
|
Interesting, I'll investigate. Thanks for all the feedback. Cool to see a project in Flutter use the Arduino CLI. :) |
I opened another issue to track the homebrew problem #1435 |
@4ntoine the gRPC interface changed quite a bit with It should be something like this in Dart.
This change has been documented in the Upgrading guide: https://arduino.github.io/arduino-cli/0.19/UPGRADING/#change-of-behaviour-of-grpc-init-function If you manage to fix this let us know if there are still issues with the |
@silvanocerza Thanks for the explanation! I will try it |
It works now, thanks! |
Ahh, i was too happy when
The crash:
|
yup, same with nightly:
|
Note i haven't fully migrated (but i guess the message is enough (same that i get with cli) and it should not crash anyway). |
I had to change your tests a bit since I had some issues with async, this is what I ran:
And this is the output:
I can't seem to reproduce the issue, the request returns correctly. Could you show the output of |
@silvanocerza There is obviously some difference in set up (probably platforms).
Anything just looking into the source code at the lines where is crashes? |
I see your
How did you install Also can you run
Simply put the CLI can't find the latest release of a platform, no idea which nor why it can't find it. I can technically already fix it but I first want to know the root cause for a more thourough fix. |
Nope, i did not remove anything intentionally, i can still see it in IDE settings:
|
Aha! You installed them with the IDE, this is something that I didn't consider. |
Yup, but i installed 1.8.2 via IDE and then upgraded it to 1.8.3 via gRPC. |
BTW i'm having this:
Can it be a reason? |
I've uninstalled all the toolchains using cli and installed "arduino:avr" again. Unfortunately i'm still having the crash.
|
I can confirm it does not crash with your code, but crashes with initializing only the first |
From the stacktrace, the null pointer exception is here Line 31 in 7415e26
platformRelease.Boards is nil or even platformRelease itself is nil (that would be really strange).
@4ntoine could you send a zip of your |
@cmaglie here you are https://dropmefiles.com/tm10S available for 14 days (it's 0.5Gb large) |
Nah, that's just a warning that certain boards are not loaded because their properties are not correct.
@4ntoine I've tested with your I need a reliable way to reproduce the issue before fixing it. 😕
Could you maybe upload the |
Unfortunately i've uninstalled "esp32" and "esp8266" toolchains so the state is different to previous.. We can close it and i will reopen if it happens again |
Let's leave it open, I want to find the cause of this issue. Could you try with the attached version of the CLI? I added more logging on certain places, it should give us more information on what's happening or which direction to go to best understand the issue. |
Hi all. I think I might have ran into the same bug. Necessary conditions
Steps to reproduce
Additional information
|
@umbynos it's working correctly now for me when I run the command line process I described in my previous reply. Thanks! |
Bug Report
Current behavior
via gRPC - requesting the list of platforms
it crashes with the stacktrace:
Expected behavior
Expected to have a response
Environment
arduino-cli version
):macOS mojave 10.14.6
Additional context
The text was updated successfully, but these errors were encountered: