Skip to content

[feature-request][grpc] Make the daemon.port optional #1260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kittaakos opened this issue Apr 12, 2021 · 3 comments
Closed

[feature-request][grpc] Make the daemon.port optional #1260

kittaakos opened this issue Apr 12, 2021 · 3 comments
Assignees
Labels
conclusion: resolved Issue was resolved topic: code Related to content of the project itself topic: gRPC Related to the gRPC interface type: enhancement Proposed improvement

Comments

@kittaakos
Copy link
Contributor

It would be great if the gRPC server for the CLI daemon could start on any available port if the daemon.port is not defined in the CLI configuration. So when the following is not specified:

daemon:
  port: "50051"

The gRPC server would start on a random port, the new IDE could read the port from the stdout, and could connect to it.

logrus.Infof("Daemon is now listening on 127.0.0.1:%s...", port)

Downstream request: arduino/arduino-ide#201

Thank you!

@per1234
Copy link
Contributor

per1234 commented Dec 9, 2021

@silvanocerza @fstasi do you think there is any need for the requested capability now that it is possible (#1585) to take the port 0 approach, as done in arduino/arduino-ide#673?

@silvanocerza
Copy link
Contributor

Yes, this can be closed.
If the user wants a random port she can either set the daemon.port config to 0 or use the --port flag.

@fstasi
Copy link

fstasi commented Dec 9, 2021

@per1234 I confirm we can close this one

@per1234 per1234 closed this as completed Dec 9, 2021
@per1234 per1234 added the conclusion: resolved Issue was resolved label Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conclusion: resolved Issue was resolved topic: code Related to content of the project itself topic: gRPC Related to the gRPC interface type: enhancement Proposed improvement
Projects
None yet
Development

No branches or pull requests

5 participants