Skip to content

Bump NodeJS version #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

aliphys
Copy link

@aliphys aliphys commented Apr 26, 2023

actions/checkout@3 is already in use e.g. in the ArduinoBLE repo:

https://github.com/arduino-libraries/ArduinoBLE/blob/55e7bb6a625f8ef8fab2a72e21ab1185dfcd70c0/.github/workflows/compile-examples.yml#L20-L21

Updating the example to use v3, in line with Github's recommendation

image

Bump arduino/compile-sketches to @2
@per1234 per1234 self-assigned this Apr 26, 2023
@per1234 per1234 added type: enhancement Proposed improvement topic: infrastructure Related to project infrastructure labels Apr 26, 2023
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your pull request @aliphys!

The workflow run failed because there is no v2 ref in the arduino/compile-sketches repository(https://github.com/arduino/compile-sketches) (that project is still in the 1.x major version series because no breaking changes have been made since the 1.0.0 release):

https://github.com/arduino/arduino-cli-example/actions/runs/4812019939/jobs/8566737117#step:1:35

Error: Unable to resolve action `arduino/compile-sketches@v2`, unable to find version `v2`

I am proposing an alternative to fully manual maintenance of the action dependencies of the workflow:

#18

That system is already in use for maintenance of the workflow in the master branch, but I forgot to set it up for this branch as well.

If #18, we would receive a subsequent pull request from Dependabot to update the outdated actions/checkout action reference.

Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Closing as superseded by the automated PR #21 produced by the newly added automated dependency management system #18

Thanks for initiating this work @aliphys!

@per1234 per1234 closed this May 2, 2023
@per1234 per1234 added the conclusion: duplicate Has already been submitted label May 2, 2023
@per1234 per1234 changed the title [AE-45] Bump NodeJS version Bump NodeJS version Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conclusion: duplicate Has already been submitted topic: infrastructure Related to project infrastructure type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants