arduino-cli inception #319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Access to PlatformRelease is now done through the Platform.GetInstalled() method that returns the installed PlatformRelease (or any of them if more than one is installed).
This avoid the overly complex properties-map handling with the ctags specific platforms.txt hanging around.
There are still some helper function to remove from utils packages, but the increase in readability is already impressive. There are some minor tweaks and small refactors here and there, but no substantial changes the code should perform exactly as before.
Release 1.4.3
Release 1.4.4
|
@ArduinoBot build this please |
|
✅ Build completed. ⬇️ Build URL: ℹ️ To test this build:
|
|
❌ Build failed. |
facchinm
approved these changes
Aug 26, 2019
|
❌ Build failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This variant of the builder is used inside arduino-cli.
Some of the buider business-logic have been moved inside the
arduinomodule of the arduino-cli (github.com/arduino/arduino-cli/arduino).The (not so) long term goal is to move all the remaining part of builder business-logic and keep in this repository only the arduino-builder executable as legacy.